Properly wait for recovery to finish #800
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With this commit we ensure that a proper schedule is chosen when waiting for shard recovery to finish. We also ensure that a short time-span where no recoveries are active (but more might continue soon) is not mistakenly treated as a condition where all recoveries have already finished. Closes elastic#796
danielmitterdorfer
added
bug
dliappis
reviewed
Oct 18, 2019
| With the operation ``wait-for-recovery`` you can wait until an ongoing index recovery finishes. The ``wait-for-recovery`` operation does not support any parameters. | ||
| With the operation ``wait-for-recovery`` you can wait until an ongoing shard recovery finishes. The ``wait-for-recovery`` operation supports the following parameters: | ||
|
|
||
| * ``completion-recheck-attempts`` (optional, defaults to 3): It might be possible that the `index recovery API <https://www.elastic.co/guide/en/elasticsearch/reference/current/indices-recovery.html>`_ reports that there are no active shard recoveries when a new one might be scheduled shortly afterwards. Therefore, this operation will check several times whether there are still no active recoveries. In between those attempts, it will wait for a time period specified by ``completion-recheck-wait-period``. |
dliappis
requested changes
Oct 18, 2019
There was a problem hiding this comment.
Thanks for fixing the operation!
I think that there are some tests that will fail if this gets merged onto the current master due to the fixes in #801
e.g. https://github.com/elastic/rally/pull/800/files#diff-ec2b07b543fca9aae6cbecf501cfe53aL227
fails with
E TypeError: 'ScheduleHandle' object is not iterable
tests/driver/driver_test.py
Outdated
| (2.0, metrics.SampleType.Normal, None, {"body": ["a"]}), | ||
| (3.0, metrics.SampleType.Normal, None, {"body": ["a"]}), | ||
| (4.0, metrics.SampleType.Normal, None, {"body": ["a"]}), | ||
| ], invocations, infinite_schedule=True) |
There was a problem hiding this comment.
I think that when we merge this to current master it's going to fail due to https://github.com/elastic/rally/pull/801/files
There was a problem hiding this comment.
Good catch! I've merged master and changed the test now in 78235be.
dliappis
added a commit
to dliappis/rally
that referenced
this pull request
Nov 15, 2019
To run an operation every 10s we specify target-interval rather than target-throughput. Relates elastic#800
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this commit we ensure that a proper schedule is chosen when waiting
for shard recovery to finish. We also ensure that a short time-span where no
recoveries are active (but more might continue soon) is not mistakenly
treated as a condition where all recoveries have already finished.
Closes #796