Add ability to restore from a snapshot #793
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With this commit we introduce new operations in Rally that allow Rally to restore data from a snapshot. Closes elastic#341
danielmitterdorfer
added
enhancement
dliappis
approved these changes
Oct 14, 2019
tests/driver/runner_test.py
Outdated
| }, | ||
| } | ||
| } | ||
|
|
tests/driver/runner_test.py
Outdated
| "total_in_bytes": 79063092, | ||
| "recovered": "65.7mb", | ||
| "recovered_in_bytes": 68891939, | ||
| }, |
tests/driver/runner_test.py
Outdated
| "total_in_bytes": 179063092, | ||
| "recovered": "165.7mb", | ||
| "recovered_in_bytes": 168891939, | ||
| }, |
docs/track.rst
Outdated
| * ``request-params`` (optional): A structure containing HTTP request parameters. | ||
|
|
||
| .. note:: | ||
| In order to ensure that the track execution only continues after a snapshot has been restored, set ``wait-for-completion`` to ``true``. In that case you should also increase the request timeout. In the example below we set it to 7200 seconds (or 2 hours):: |
There was a problem hiding this comment.
How about joining the two sentences like ...
In order to ensure that the track execution only continues after a snapshot has been restored, set
wait-for-completiontotrueand increase the request timeout.
docs/track.rst
Outdated
| "request_timeout": 7200 | ||
| } | ||
|
|
||
| However, this might not work if a proxy is in between the client and Elasticsearch and that proxy has a shorter request timeout configured than the client. In that case, keep the default value for ``wait-for-completion`` and instead add a ``wait-for-recovery`` runner in the next step. This has the additional advantage that you'll get a progress report while the snapshot is being restored. |
There was a problem hiding this comment.
Somehow that looks out of place to me when this is used in every other sentence and everything looks very specific. How about: In this case, keep the default value for ``wait-for-completion`` and instead add a ``wait-for-recovery`` runner in the next step.
This was referenced Oct 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this commit we introduce new operations in Rally that allow Rally
to restore data from a snapshot.
Closes #341