Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Honor ingest-percentage for bulks #768

Merged

Commits on Sep 10, 2019

  1. Honor ingest-percentage for bulks

    With this commit we honor the parameter `ingest-percentage` again for bulk
    requests. Before elastic#763, the method `size()` was used to determine upfront when a
    parameter source is exhausted. When we changed the API then in elastic#763 the
    parameter source's progress indication was instead done with the
    `percent_completed` property but this is only informational and the parameter
    source is required to raise `StopIteration` to indicate completion. This means
    that `ingest-percentage` was not considered anymore for bulks but instead we
    always read the input file(s) completely and then terminated with
    `StopIteration`.
    
    Relates elastic#763
    danielmitterdorfer committed Sep 10, 2019
    Configuration menu
    Copy the full SHA
    713c612 View commit details
    Browse the repository at this point in the history