Start release process creating NOTICE #765
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With this commit we move the creation of the NOTICE file to the beginning of the release process. As this depends on pulling files from repositories that are not under our control, it can fail. By doing this as the first step, we can correct any errors before other tasks have modified state.
danielmitterdorfer
added
enhancement
|
Thanks for the review! :) |
novosibman
pushed a commit
to novosibman/rally
that referenced
this pull request
Oct 2, 2019
With this commit we move the creation of the NOTICE file to the beginning of the release process. As this depends on pulling files from repositories that are not under our control, it can fail. By doing this as the first step, we can correct any errors before other tasks have modified state. Relates elastic#765
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this commit we move the creation of the NOTICE file to the
beginning of the release process. As this depends on pulling files from
repositories that are not under our control, it can fail. By doing this
as the first step, we can correct any errors before other tasks have
modified state.