Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to retry until success #761

Merged

Conversation

danielmitterdorfer
Copy link
Member

@danielmitterdorfer danielmitterdorfer commented Sep 3, 2019

With this commit we add a new parameter retry-until-success to all
retryable operations (e.g. cluster health) that will allow to retry
those operations until they report success. Note that this is actually
just a convenience property that will increase the number of retries to
sys.maxsize.

With this commit we add a new parameter `retry-until-success` to all
retryable operations (e.g. cluster health) that will allow to retry
those operations until they report success. Note that this is actually
just a convenience property that will increase the number of retries to
`sys.maxint`.
@danielmitterdorfer danielmitterdorfer added enhancement Improves the status quo :Usability Makes Rally easier to use :Load Driver Changes that affect the core of the load driver such as scheduling, the measurement approach etc. labels Sep 3, 2019
@danielmitterdorfer danielmitterdorfer added this to the 1.3.0 milestone Sep 3, 2019
Copy link
Contributor

@dliappis dliappis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@danielmitterdorfer danielmitterdorfer merged commit f0bed1e into elastic:master Sep 4, 2019
@danielmitterdorfer danielmitterdorfer deleted the eternal-flame branch September 4, 2019 07:25
@danielmitterdorfer
Copy link
Member Author

Thanks for the review!

novosibman pushed a commit to novosibman/rally that referenced this pull request Oct 2, 2019
With this commit we add a new parameter `retry-until-success` to all
retryable operations (e.g. cluster health) that will allow to retry
those operations until they report success. Note that this is actually
just a convenience property that will increase the number of retries to
`sys.maxint`.

Relates elastic#761
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improves the status quo :Load Driver Changes that affect the core of the load driver such as scheduling, the measurement approach etc. :Usability Makes Rally easier to use
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants