Show track and team revision when listing races #759
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ebadyano
added
:Reporting
esrally/metrics.py
Outdated
| @@ -1314,11 +1314,13 @@ def from_dict(cls, d): | |||
| else: | |||
| user_tags = {} | |||
|
|
|||
| # Don't restore a few properties like cluster because they (a) cannot be reconstructed easily without knowledge of other modules | |||
| team_revision = d.get("cluster").get("team-revision") | |||
There was a problem hiding this comment.
If there is no cluster property this will fail because #get() will return None.
There was a problem hiding this comment.
thank you for catching this!
| @@ -1160,11 +1160,11 @@ def format_dict(d): | |||
| races = [] | |||
| for race in race_store(cfg).list(): | |||
| races.append([race.trial_id, time.to_iso8601(race.trial_timestamp), race.track, format_dict(race.track_params), race.challenge_name, race.car_name, | |||
| format_dict(race.user_tags)]) | |||
| format_dict(race.user_tags), race.track_revision, race.cluster.get("team-revision")]) | |||
There was a problem hiding this comment.
fyi: I thought whether we might want to change the order here and group track-related properties and team-related properties but those two properties are so special that it's probably ok to leave them at the end.
danielmitterdorfer
approved these changes
Sep 3, 2019
esrally/metrics.py
Outdated
| @@ -1314,7 +1314,9 @@ def from_dict(cls, d): | |||
| else: | |||
| user_tags = {} | |||
|
|
|||
| team_revision = d.get("cluster").get("team-revision") | |||
| team_revision = None | |||
| if d.get("cluster"): | |||
There was a problem hiding this comment.
I think more idiomatic is if "cluster" in d:
novosibman
pushed a commit
to novosibman/rally
that referenced
this pull request
Oct 2, 2019
Show track and team revision when listing races Closes elastic#665
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #665