Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve error message on SSL errors #758

Merged
merged 1 commit into from
Sep 3, 2019
Merged

Improve error message on SSL errors #758

merged 1 commit into from
Sep 3, 2019

Conversation

danielmitterdorfer
Copy link
Member

With this commit we check for SSL-related errors when waiting for the
REST layer to be available and provide a better error message when the
user attempts to connect via SSL to a http endpoint.

Closes #757

@danielmitterdorfer
Improve error message on SSL errors
71a7d54 
With this commit we check for SSL-related errors when waiting for the
REST layer to be available and provide a better error message when the
user attempts to connect via SSL to a http endpoint.

Closes elastic#757
@danielmitterdorfer danielmitterdorfer added enhancement Improves the status quo :Usability Makes Rally easier to use :Benchmark Candidate Management Anything affecting how Rally sets up Elasticsearch labels Aug 30, 2019
@danielmitterdorfer danielmitterdorfer added this to the 1.3.0 milestone Aug 30, 2019
ebadyano
ebadyano approved these changes Sep 3, 2019
View reviewed changes
Copy link
Contributor

@ebadyano ebadyano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

@danielmitterdorfer danielmitterdorfer merged commit 417fc0b into elastic:master Sep 3, 2019
@danielmitterdorfer
Copy link
Member Author

Thanks for the review! :)

@danielmitterdorfer danielmitterdorfer deleted the ssl-rest-check branch September 3, 2019 12:10
novosibman pushed a commit to novosibman/rally that referenced this pull request Oct 2, 2019
@danielmitterdorfer @novosibman
Improve error message on SSL errors
7b9e03c 
With this commit we check for SSL-related errors when waiting for the
REST layer to be available and provide a better error message when the
user attempts to connect via SSL to a http endpoint.

Closes elastic#757
Relates elastic#758
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ebadyano ebadyano ebadyano approved these changes

Assignees
No one assigned
Labels
:Benchmark Candidate Management Anything affecting how Rally sets up Elasticsearch enhancement Improves the status quo :Usability Makes Rally easier to use
Projects
None yet
Milestone
1.3.0
Development

Successfully merging this pull request may close these issues.

Provide more clues to what's causing the error SSL: WRONG_VERSION_NUMBER
2 participants
@danielmitterdorfer @ebadyano