Log git output #747
Merged
Log git output #747
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With this commit we send git output to logs (except when cloning a repo initially as it might require the user to enter credentials). This avoids that git output interferes with Rally's. This is needed e.g. when Rally's `download` subcommand is invoked where we usually expect only a JSON fragment as output. Closes elastic#745
danielmitterdorfer
added
bug
|
Thanks for the review to both of you! :) |
danielmitterdorfer
added a commit
to danielmitterdorfer/rally
that referenced
this pull request
Aug 21, 2019
With this commit we retrieve the correct commit hash for a given timestamp separately from the actual checkout call as this has caused problems. Relates elastic#747
ebadyano
pushed a commit
that referenced
this pull request
Aug 21, 2019
With this commit we retrieve the correct commit hash for a given timestamp separately from the actual checkout call as this has caused problems. Relates #747
novosibman
pushed a commit
to novosibman/rally
that referenced
this pull request
Oct 2, 2019
With this commit we send git output to logs (except when cloning a repo initially as it might require the user to enter credentials). This avoids that git output interferes with Rally's. This is needed e.g. when Rally's `download` subcommand is invoked where we usually expect only a JSON fragment as output. Closes elastic#745 Relates elastic#747
novosibman
pushed a commit
to novosibman/rally
that referenced
this pull request
Oct 2, 2019
With this commit we retrieve the correct commit hash for a given timestamp separately from the actual checkout call as this has caused problems. Relates elastic#747
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this commit we send git output to logs (except when cloning a repo
initially as it might require the user to enter credentials). This
avoids that git output interferes with Rally's. This is needed e.g. when
Rally's
downloadsubcommand is invoked where we usually expect only aJSON fragment as output.
Closes #745