Allow to set distribution version as parameter #728
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With this commit we allow (again) to set the distribution version as a command line parameter even in cases where it does not seem to be useful initially, like the `benchmark-only` pipeline. However, if Rally fails to determine the cluster version (for whatever reason) it can be useful to be able to override this on the command line. Similarly, it can be useful to override this when benchmarking a source build that is *not* based on master but rather of an older branch. In these cases, Rally would still take the right decisions with some guidance by the user.
danielmitterdorfer
added
enhancement
|
Thanks! :) |
ebadyano
pushed a commit
to ebadyano/rally
that referenced
this pull request
Jul 16, 2019
With this commit we allow (again) to set the distribution version as a command line parameter even in cases where it does not seem to be useful initially, like the `benchmark-only` pipeline. However, if Rally fails to determine the cluster version (for whatever reason) it can be useful to be able to override this on the command line. Similarly, it can be useful to override this when benchmarking a source build that is *not* based on master but rather of an older branch. In these cases, Rally would still take the right decisions with some guidance by the user. Relates elastic#728
novosibman
pushed a commit
to novosibman/rally
that referenced
this pull request
Aug 12, 2019
With this commit we allow (again) to set the distribution version as a command line parameter even in cases where it does not seem to be useful initially, like the `benchmark-only` pipeline. However, if Rally fails to determine the cluster version (for whatever reason) it can be useful to be able to override this on the command line. Similarly, it can be useful to override this when benchmarking a source build that is *not* based on master but rather of an older branch. In these cases, Rally would still take the right decisions with some guidance by the user. Relates elastic#728
novosibman
pushed a commit
to novosibman/rally
that referenced
this pull request
Aug 12, 2019
With this commit we allow (again) to set the distribution version as a command line parameter even in cases where it does not seem to be useful initially, like the `benchmark-only` pipeline. However, if Rally fails to determine the cluster version (for whatever reason) it can be useful to be able to override this on the command line. Similarly, it can be useful to override this when benchmarking a source build that is *not* based on master but rather of an older branch. In these cases, Rally would still take the right decisions with some guidance by the user. Relates elastic#728
novosibman
pushed a commit
to novosibman/rally
that referenced
this pull request
Aug 12, 2019
With this commit we allow (again) to set the distribution version as a command line parameter even in cases where it does not seem to be useful initially, like the `benchmark-only` pipeline. However, if Rally fails to determine the cluster version (for whatever reason) it can be useful to be able to override this on the command line. Similarly, it can be useful to override this when benchmarking a source build that is *not* based on master but rather of an older branch. In these cases, Rally would still take the right decisions with some guidance by the user. Relates elastic#728
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this commit we allow (again) to set the distribution version as a
command line parameter even in cases where it does not seem to be useful
initially, like the
benchmark-onlypipeline. However, if Rally failsto determine the cluster version (for whatever reason) it can be useful
to be able to override this on the command line. Similarly, it can be
useful to override this when benchmarking a source build that is not
based on master but rather of an older branch. In these cases, Rally
would still take the right decisions with some guidance by the user.