Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't check complete list of parameters in integration test #726

Merged

Conversation

dliappis
Copy link
Contributor

To check the complete list of exposed track parameters in an integration
test we rely on parameters in rally-tracks which can change over
time[1].
Be more lenient by just checking the unused track parameters.

[1] elastic/rally-tracks@4080dc9

To check the complete list of exposed track parameters in an integration
 test we rely on parameters in rally-tracks which can change over
 time[1].
Be more lenient by just checking the unused track parameters.

[1] elastic/rally-tracks@4080dc9
@dliappis dliappis added the :misc Changes that don't affect users directly: linter fixes, test improvements, etc. label Jul 11, 2019
@dliappis dliappis added this to the 1.3.0 milestone Jul 11, 2019
Copy link
Member

@danielmitterdorfer danielmitterdorfer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the fix! LGTM :)

@dliappis dliappis merged commit 9b9c7e0 into elastic:master Jul 11, 2019
@dliappis dliappis deleted the dont-fail-params-test-with-new-params branch July 11, 2019 11:05
@danielmitterdorfer danielmitterdorfer added the enhancement Improves the status quo label Jul 11, 2019
ebadyano pushed a commit to ebadyano/rally that referenced this pull request Jul 16, 2019
To check the complete list of exposed track parameters in an integration
 test we rely on parameters in rally-tracks which can change over
 time[1].
Be more lenient by just checking the unused track parameters.

Relates elastic#726

[1] elastic/rally-tracks@4080dc9
novosibman pushed a commit to novosibman/rally that referenced this pull request Aug 12, 2019
To check the complete list of exposed track parameters in an integration
 test we rely on parameters in rally-tracks which can change over
 time[1].
Be more lenient by just checking the unused track parameters.

Relates elastic#726

[1] elastic/rally-tracks@4080dc9
novosibman pushed a commit to novosibman/rally that referenced this pull request Aug 12, 2019
To check the complete list of exposed track parameters in an integration
 test we rely on parameters in rally-tracks which can change over
 time[1].
Be more lenient by just checking the unused track parameters.

Relates elastic#726

[1] elastic/rally-tracks@4080dc9
novosibman pushed a commit to novosibman/rally that referenced this pull request Aug 12, 2019
To check the complete list of exposed track parameters in an integration
 test we rely on parameters in rally-tracks which can change over
 time[1].
Be more lenient by just checking the unused track parameters.

Relates elastic#726

[1] elastic/rally-tracks@4080dc9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improves the status quo :misc Changes that don't affect users directly: linter fixes, test improvements, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants