Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop support for Elasticsearch 1.x #716

Merged
merged 3 commits into from
Jul 11, 2019
Merged

Drop support for Elasticsearch 1.x #716

merged 3 commits into from
Jul 11, 2019

Conversation

danielmitterdorfer
Copy link
Member

With this commit we remove support in Rally to benchmark Elasticsearch
1.x.

Closes #715

@danielmitterdorfer
Drop support for Elasticsearch 1.x
e84ac47 
With this commit we remove support in Rally to benchmark Elasticsearch
1.x.

Closes elastic#715
@danielmitterdorfer danielmitterdorfer added this to the 1.3.0 milestone Jun 17, 2019
@danielmitterdorfer danielmitterdorfer added :Load Driver Changes that affect the core of the load driver such as scheduling, the measurement approach etc. blocked This item cannot be finished because of a dependency breaking Non-backwards compatible change enhancement Improves the status quo and removed blocked This item cannot be finished because of a dependency labels Jun 17, 2019
@danielmitterdorfer danielmitterdorfer mentioned this pull request Jun 17, 2019
Closed
3 tasks
danielmitterdorfer added a commit that referenced this pull request Jun 18, 2019
@danielmitterdorfer
Change supported Elasticsearch version
f09fffa 
With this commit we change the supported version for Elasticsearch to
1.7.0 as Rally 1.2.0 will still support that version. We will drop
support in a later PR (see #716)

Relates #716
danielmitterdorfer added a commit to danielmitterdorfer/rally that referenced this pull request Jul 8, 2019
@danielmitterdorfer
Always exit on OOME
696a01e 
With this commit we add the JVM flag `ExitOnOutOfMemoryError`
unconditionally when Elasticsearch is configured by Rally. Previously we
had to check whether the JVM in use supports this flag because we
supported Elasticsearch 1.x which can be run with Java 1.7. As the JVM flag
has only been introduced with Java 8, we had a check in place. Now that
we have dropped support for Elasticsearch 1.x (in elastic#716), we can safely
assume that the JVM supports this flag and unconditionally set it.

Relates elastic#715
@danielmitterdorfer danielmitterdorfer mentioned this pull request Jul 8, 2019
Merged
drawlerr
drawlerr approved these changes Jul 10, 2019
View reviewed changes
Copy link
Contributor

@drawlerr drawlerr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@danielmitterdorfer danielmitterdorfer merged commit 2c46267 into elastic:master Jul 11, 2019
@danielmitterdorfer
Copy link
Member Author

Thanks for the review! :)

@danielmitterdorfer danielmitterdorfer deleted the drop-1x-support branch July 11, 2019 08:11
danielmitterdorfer added a commit that referenced this pull request Jul 11, 2019
@danielmitterdorfer
Always exit on OOME
72c2481 
With this commit we add the JVM flag `ExitOnOutOfMemoryError`
unconditionally when Elasticsearch is configured by Rally. Previously we
had to check whether the JVM in use supports this flag because we
supported Elasticsearch 1.x which can be run with Java 1.7. As the JVM flag
has only been introduced with Java 8, we had a check in place. Now that
we have dropped support for Elasticsearch 1.x (in #716), we can safely
assume that the JVM supports this flag and unconditionally set it.

Relates #715
Relates #723
danielmitterdorfer added a commit to danielmitterdorfer/rally that referenced this pull request Jul 16, 2019
@danielmitterdorfer
Drop 1.x support for cluster metadata
8747c9d 
With this commit we remove support for Elasticsearch 1.x when retrieving
cluster metadata. This is a leftover from elastic#716

Relates elastic#716
@danielmitterdorfer danielmitterdorfer mentioned this pull request Jul 16, 2019
Merged
danielmitterdorfer added a commit that referenced this pull request Jul 16, 2019
@danielmitterdorfer
Drop 1.x support for cluster metadata
d22cf3f 
With this commit we remove support for Elasticsearch 1.x when retrieving
cluster metadata. This is a leftover from #716

Relates #716
Relates #729
ebadyano pushed a commit to ebadyano/rally that referenced this pull request Jul 16, 2019
@danielmitterdorfer @ebadyano
Drop support for Elasticsearch 1.x
0f456d7 
With this commit we remove support in Rally to benchmark Elasticsearch
1.x.

Relates elastic#715
Relates elastic#716
ebadyano pushed a commit to ebadyano/rally that referenced this pull request Jul 16, 2019
@danielmitterdorfer @ebadyano
Always exit on OOME
28577c6 
With this commit we add the JVM flag `ExitOnOutOfMemoryError`
unconditionally when Elasticsearch is configured by Rally. Previously we
had to check whether the JVM in use supports this flag because we
supported Elasticsearch 1.x which can be run with Java 1.7. As the JVM flag
has only been introduced with Java 8, we had a check in place. Now that
we have dropped support for Elasticsearch 1.x (in elastic#716), we can safely
assume that the JVM supports this flag and unconditionally set it.

Relates elastic#715
Relates elastic#723
ebadyano pushed a commit to ebadyano/rally that referenced this pull request Jul 16, 2019
@danielmitterdorfer @ebadyano
Drop 1.x support for cluster metadata
8e64141 
With this commit we remove support for Elasticsearch 1.x when retrieving
cluster metadata. This is a leftover from elastic#716

Relates elastic#716
Relates elastic#729
novosibman pushed a commit to novosibman/rally that referenced this pull request Aug 12, 2019
@danielmitterdorfer @novosibman
Drop support for Elasticsearch 1.x
cee2e0c 
With this commit we remove support in Rally to benchmark Elasticsearch
1.x.

Relates elastic#715
Relates elastic#716
novosibman pushed a commit to novosibman/rally that referenced this pull request Aug 12, 2019
@danielmitterdorfer @novosibman
Always exit on OOME
d488ebf 
With this commit we add the JVM flag `ExitOnOutOfMemoryError`
unconditionally when Elasticsearch is configured by Rally. Previously we
had to check whether the JVM in use supports this flag because we
supported Elasticsearch 1.x which can be run with Java 1.7. As the JVM flag
has only been introduced with Java 8, we had a check in place. Now that
we have dropped support for Elasticsearch 1.x (in elastic#716), we can safely
assume that the JVM supports this flag and unconditionally set it.

Relates elastic#715
Relates elastic#723
novosibman pushed a commit to novosibman/rally that referenced this pull request Aug 12, 2019
@danielmitterdorfer @novosibman
Drop 1.x support for cluster metadata
255f269 
With this commit we remove support for Elasticsearch 1.x when retrieving
cluster metadata. This is a leftover from elastic#716

Relates elastic#716
Relates elastic#729
novosibman pushed a commit to novosibman/rally that referenced this pull request Aug 12, 2019
@danielmitterdorfer @ru-az
Drop support for Elasticsearch 1.x
da71e3d 
With this commit we remove support in Rally to benchmark Elasticsearch
1.x.

Relates elastic#715
Relates elastic#716
novosibman pushed a commit to novosibman/rally that referenced this pull request Aug 12, 2019
@danielmitterdorfer @ru-az
Always exit on OOME
a0b83dd 
With this commit we add the JVM flag `ExitOnOutOfMemoryError`
unconditionally when Elasticsearch is configured by Rally. Previously we
had to check whether the JVM in use supports this flag because we
supported Elasticsearch 1.x which can be run with Java 1.7. As the JVM flag
has only been introduced with Java 8, we had a check in place. Now that
we have dropped support for Elasticsearch 1.x (in elastic#716), we can safely
assume that the JVM supports this flag and unconditionally set it.

Relates elastic#715
Relates elastic#723
novosibman pushed a commit to novosibman/rally that referenced this pull request Aug 12, 2019
@danielmitterdorfer @ru-az
Drop 1.x support for cluster metadata
b2e0018 
With this commit we remove support for Elasticsearch 1.x when retrieving
cluster metadata. This is a leftover from elastic#716

Relates elastic#716
Relates elastic#729
novosibman pushed a commit to novosibman/rally that referenced this pull request Aug 12, 2019
@danielmitterdorfer @novosibman
Drop support for Elasticsearch 1.x
51ad1a0 
With this commit we remove support in Rally to benchmark Elasticsearch
1.x.

Relates elastic#715
Relates elastic#716
novosibman pushed a commit to novosibman/rally that referenced this pull request Aug 12, 2019
@danielmitterdorfer @novosibman
Always exit on OOME
738953f 
With this commit we add the JVM flag `ExitOnOutOfMemoryError`
unconditionally when Elasticsearch is configured by Rally. Previously we
had to check whether the JVM in use supports this flag because we
supported Elasticsearch 1.x which can be run with Java 1.7. As the JVM flag
has only been introduced with Java 8, we had a check in place. Now that
we have dropped support for Elasticsearch 1.x (in elastic#716), we can safely
assume that the JVM supports this flag and unconditionally set it.

Relates elastic#715
Relates elastic#723
novosibman pushed a commit to novosibman/rally that referenced this pull request Aug 12, 2019
@danielmitterdorfer @novosibman
Drop 1.x support for cluster metadata
068f70f 
With this commit we remove support for Elasticsearch 1.x when retrieving
cluster metadata. This is a leftover from elastic#716

Relates elastic#716
Relates elastic#729
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drawlerr drawlerr drawlerr approved these changes

Assignees
No one assigned
Labels
breaking Non-backwards compatible change enhancement Improves the status quo :Load Driver Changes that affect the core of the load driver such as scheduling, the measurement approach etc.
Projects
None yet
Milestone
1.3.0
Development

Successfully merging this pull request may close these issues.

Drop support for Elasticsearch 1.x
2 participants
@danielmitterdorfer @drawlerr