Check tags in track and team repos #713
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With this commit Rally does not only check for branch matches but also for matching tags in track and team repos. This allows to "freeze" support for older versions of Elasticsearch, i.e. once we drop support for Elasticsearch 1.x, we can tag the branch `1` in rally-teams and rally-tracks as `v1` (using a `v` prefix as convention for tags). Rally can then still pick up configurations for these older versions that our out of maintenance.
danielmitterdorfer
added
enhancement
This was referenced Jun 17, 2019
|
Thanks for the quick review @ebadyano! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this commit Rally does not only check for branch matches but also
for matching tags in track and team repos. This allows to "freeze"
support for older versions of Elasticsearch, i.e. once we drop support
for Elasticsearch 1.x, we can tag the branch
1in rally-teams andrally-tracks as
v1(using avprefix as convention for tags). Rallycan then still pick up configurations for these older versions that are
out of maintenance.