Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Align default request param extraction for queries #708

Merged
merged 1 commit into from
Jun 7, 2019
Merged

Align default request param extraction for queries #708

merged 1 commit into from
Jun 7, 2019

Conversation

danielmitterdorfer
Copy link
Member

With this commit we align the extraction of default request parameters
for the query runner which comes in two flavors: request body search
and scroll search.

@danielmitterdorfer
Align default request param extraction for queries
8a084c2 
With this commit we align the extraction of default request parameters
for the `query` runner which comes in two flavors: request body search
and scroll search.
@danielmitterdorfer danielmitterdorfer added enhancement Improves the status quo :misc Changes that don't affect users directly: linter fixes, test improvements, etc. labels Jun 7, 2019
@danielmitterdorfer danielmitterdorfer added this to the 1.2.0 milestone Jun 7, 2019
dliappis
dliappis approved these changes Jun 7, 2019
View reviewed changes
Copy link
Contributor

@dliappis dliappis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@danielmitterdorfer
Copy link
Member Author

Thanks for the review! :)

@danielmitterdorfer danielmitterdorfer merged commit 69cb36d into elastic:master Jun 7, 2019
@danielmitterdorfer danielmitterdorfer deleted the align-default-req-params-for-search branch June 7, 2019 10:52
@dliappis dliappis modified the milestones: 1.2.0, 1.2.1 Jun 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dliappis dliappis dliappis approved these changes

Assignees
No one assigned
Labels
enhancement Improves the status quo :misc Changes that don't affect users directly: linter fixes, test improvements, etc.
Projects
None yet
Milestone
1.2.1
Development

Successfully merging this pull request may close these issues.
2 participants
@danielmitterdorfer @dliappis