Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Assume UTC timezone if not specified #693

Merged
merged 2 commits into from
May 23, 2019
Merged

Assume UTC timezone if not specified #693

merged 2 commits into from
May 23, 2019

Conversation

drawlerr
Copy link
Contributor

Python naive timestamp delta assumes local timezone, which makes template rendering inconsistent between timezones.

Closes #692.

danielmitterdorfer
danielmitterdorfer reviewed May 23, 2019
View reviewed changes
Copy link
Member

@danielmitterdorfer danielmitterdorfer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for spotting this! I left one suggestion but otherwise it's fine.

esrally/time.py Outdated Show resolved Hide resolved
@danielmitterdorfer danielmitterdorfer added :Track Management New operations, changes in the track format, track download changes and the like bug Something's wrong labels May 23, 2019
@danielmitterdorfer danielmitterdorfer added this to the 1.1.1 milestone May 23, 2019
dliappis
dliappis approved these changes May 23, 2019
View reviewed changes
Copy link
Contributor

@dliappis dliappis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also LGTM from me. Agreed on exposing it in days_ago() in esrally/time.py.

@drawlerr drawlerr merged commit 1a951d5 into elastic:master May 23, 2019
@drawlerr drawlerr deleted the fix-time-test branch May 23, 2019 13:30
@dliappis dliappis modified the milestones: 1.2.0, 1.2.1 Jun 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielmitterdorfer danielmitterdorfer danielmitterdorfer left review comments

@dliappis dliappis dliappis approved these changes

Assignees
No one assigned
Labels
bug Something's wrong :Track Management New operations, changes in the track format, track download changes and the like
Projects
None yet
Milestone
1.2.1
Development

Successfully merging this pull request may close these issues.

Assertion failure in TemplateRenderTests.test_render_simple_template
3 participants
@drawlerr @danielmitterdorfer @dliappis