Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade Jinja to 2.10.1 #678

Merged
merged 1 commit into from
Apr 11, 2019
Merged

Upgrade Jinja to 2.10.1 #678

merged 1 commit into from
Apr 11, 2019

Conversation

danielmitterdorfer
Copy link
Member

No description provided.

@danielmitterdorfer danielmitterdorfer added enhancement Improves the status quo :misc Changes that don't affect users directly: linter fixes, test improvements, etc. labels Apr 10, 2019
@danielmitterdorfer danielmitterdorfer added this to the 1.1.0 milestone Apr 10, 2019
dliappis
dliappis approved these changes Apr 10, 2019
View reviewed changes
Copy link
Contributor

@dliappis dliappis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; didn't know if you tested this with make test/it, I did it myself just in case and they passed.

@danielmitterdorfer
Copy link
Member Author

Yes, I also tested that locally. Thanks for the review! :)

@danielmitterdorfer danielmitterdorfer merged commit 37a748a into elastic:master Apr 11, 2019
@danielmitterdorfer danielmitterdorfer deleted the upgrade-jinja branch April 11, 2019 05:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dliappis dliappis dliappis approved these changes

Assignees
No one assigned
Labels
enhancement Improves the status quo :misc Changes that don't affect users directly: linter fixes, test improvements, etc.
Projects
None yet
Milestone
1.1.0
Development

Successfully merging this pull request may close these issues.
2 participants
@danielmitterdorfer @dliappis