Add user tags when comparing races #660
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change will include the race user tags along side with the date, challenge, car
danielmitterdorfer
added
enhancement
alexsapran
commented
Mar 4, 2019
esrally/reporter.py
Outdated
| @@ -675,12 +675,18 @@ def report(self, r1, r2): | |||
| if r1.challenge_name: | |||
| print_internal(" Challenge: %s" % r1.challenge_name) | |||
| print_internal(" Car: %s" % r1.car_name) | |||
| if r1.user_tags: | |||
| r1_user_tags = ", ".join(["%s=%s" % (k, v) for k, v in sorted(r1.user_tags.items())]) | |||
| print_internal(" User Tags: %s" % r1_user_tags) | |||
There was a problem hiding this comment.
or better User tags (lower t vs capital)
danielmitterdorfer
approved these changes
Mar 5, 2019
esrally/reporter.py
Outdated
| @@ -675,12 +675,18 @@ def report(self, r1, r2): | |||
| if r1.challenge_name: | |||
| print_internal(" Challenge: %s" % r1.challenge_name) | |||
| print_internal(" Car: %s" % r1.car_name) | |||
| if r1.user_tags: | |||
| r1_user_tags = ", ".join(["%s=%s" % (k, v) for k, v in sorted(r1.user_tags.items())]) | |||
| print_internal(" User Tags: %s" % r1_user_tags) | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change will include the race user tags along side with the date, challenge,
car
Example:
$ ./rally compare --contender=20190227T161026Z --baseline=20190228T150825Z ____ ____ / __ \____ _/ / /_ __ / /_/ / __ `/ / / / / / / _, _/ /_/ / / / /_/ / /_/ |_|\__,_/_/_/\__, / /____/ Comparing baseline Race timestamp: 2019-02-28 15:08:25 Challenge: append-no-conflicts-with-ingest-pipeline Car: external User Tags: intention=combined, template=io with contender Race timestamp: 2019-02-27 16:10:26 Challenge: append-no-conflicts-with-ingest-pipeline Car: external User Tags: intention=combined, template=ioFixes: #657