Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make types optional #647

Merged
merged 1 commit into from
Feb 15, 2019
Merged

Make types optional #647

merged 1 commit into from
Feb 15, 2019

Conversation

danielmitterdorfer
Copy link
Member

With this commit we make types an optional concept in Rally as types
have been removed from the Elasticsearch APIs with 7.0.0. It is still
possible to use types for older versions of Elasticsearch though.

@danielmitterdorfer
Make types optional
9c2c395 
With this commit we make types an optional concept in Rally as types
have been removed from the Elasticsearch APIs with 7.0.0. It is still
possible to use types for older versions of Elasticsearch though.
@danielmitterdorfer danielmitterdorfer added enhancement Improves the status quo :Track Management New operations, changes in the track format, track download changes and the like :Load Driver Changes that affect the core of the load driver such as scheduling, the measurement approach etc. labels Feb 14, 2019
@danielmitterdorfer danielmitterdorfer added this to the 1.0.4 milestone Feb 14, 2019
danielmitterdorfer added a commit to danielmitterdorfer/rally-tracks that referenced this pull request Feb 14, 2019
@danielmitterdorfer
Remove document types
c14453b 
With this commit we remove document types from all Rally tracks as they
have been removed with Elasticsearch 7.0.0.

Relates elastic/rally#647
@danielmitterdorfer danielmitterdorfer mentioned this pull request Feb 14, 2019
Merged
ebadyano
ebadyano approved these changes Feb 14, 2019
View reviewed changes
Copy link
Contributor

@ebadyano ebadyano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! Thanks!

dliappis
dliappis approved these changes Feb 14, 2019
View reviewed changes
Copy link
Contributor

@dliappis dliappis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM this looks great.

@danielmitterdorfer
Copy link
Member Author

Thanks both for your quick review!

@danielmitterdorfer danielmitterdorfer merged commit 317d833 into elastic:master Feb 15, 2019
@danielmitterdorfer danielmitterdorfer deleted the optional-types branch February 15, 2019 10:15
danielmitterdorfer added a commit to elastic/rally-tracks that referenced this pull request Feb 25, 2019
@danielmitterdorfer
Remove document types
c6b0bd2 
With this commit we remove document types from all Rally tracks as they
have been removed with Elasticsearch 7.0.0.

Relates elastic/rally#647
Relates #66
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dliappis dliappis dliappis approved these changes

@ebadyano ebadyano ebadyano approved these changes

Assignees
No one assigned
Labels
enhancement Improves the status quo :Load Driver Changes that affect the core of the load driver such as scheduling, the measurement approach etc. :Track Management New operations, changes in the track format, track download changes and the like
Projects
None yet
Milestone
1.0.4
Development

Successfully merging this pull request may close these issues.
3 participants
@danielmitterdorfer @dliappis @ebadyano