Allow passing any request parameter to the create index API #642
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elastic/rally-tracks#64 requires passing a parameter in the create-index runner, however, the underlying ES Python client method[1] doesn't support it. Additionally our docs[2] hint that this is possible, but it isn't. This isn't caught by unit tests as the ES client is mocked and an integration test is needed (TODO in a separate PR). Directly call es.transport.perform_request to create an index, allowing passing of any arbitrary parameter (such as `include_type_name`) to the create index Elasticsearch API. [1] https://elasticsearch-py.readthedocs.io/en/master/api.html?highlight=indices%20create#elasticsearch.client.IndicesClient.create [2] https://esrally.readthedocs.io/en/stable/track.html#create-index
dliappis
added
enhancement
|
We'll need to add an integration test to catch what the unit test didn't catch here (i.e. passing parameters for create-index), but I thought it can be done in a separate PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
elastic/rally-tracks#64 requires passing a
parameter in the create-index runner, however, the underlying ES Python
client method[1] doesn't support it. Additionally our docs[2] hint
that this is possible, but it isn't.
This leads to errors like:
create() got an unexpected keyword argument 'include_type_name'.This isn't caught by unit tests as the ES client is mocked and an
integration test is needed (TODO in a separate PR).
Directly call es.transport.perform_request to create an index, allowing
passing of any arbitrary parameter (such as
include_type_name) tothe create index Elasticsearch API.
[1] https://elasticsearch-py.readthedocs.io/en/master/api.html?highlight=indices%20create#elasticsearch.client.IndicesClient.create
[2] https://esrally.readthedocs.io/en/stable/track.html#create-index