Correct recorder-based sampling interval #638
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With this commit we remove the call to `time.sleep` from the CCR stats recorder's `record` method. This call is redundant because the sampler thread that manages the recorder already calls `time.sleep`. This means that the effective sample rate is effectively half of the specified one.
danielmitterdorfer
added
bug
dliappis
reviewed
Jan 29, 2019
There was a problem hiding this comment.
Thanks for catching this!
Isn't node-stats also affected by this though in
rally/esrally/mechanic/telemetry.py
Line 552 in 5ec3161
danielmitterdorfer
changed the title
|
Thanks, merged! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this commit we remove the call to
time.sleepfrom the node stats and CCRstats recorder's
recordmethod. Thes calls are redundant because the samplerthread that manages the recorder already calls
time.sleep. This means that theeffective sample rate is effectively half of the specified one.