Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error message on missing repo directory #630

Conversation

danielmitterdorfer
Copy link
Member

So far we only check whether repo is a valid working copy and raise an
error if it is not. With this commit we add a further check if the
directory exists at all (because that case needs to be fixed differently
by the user).

So far we only check whether repo is a valid working copy and raise an
error if it is not. With this commit we add a further check if the
directory exists at all (because that case needs to be fixed differently
by the user).
@danielmitterdorfer danielmitterdorfer added enhancement Improves the status quo :Track Management New operations, changes in the track format, track download changes and the like :Benchmark Candidate Management Anything affecting how Rally sets up Elasticsearch labels Jan 22, 2019
@danielmitterdorfer danielmitterdorfer added this to the 1.0.3 milestone Jan 22, 2019
@danielmitterdorfer danielmitterdorfer modified the milestones: 1.0.3, 1.0.4 Jan 22, 2019
Copy link
Contributor

@ebadyano ebadyano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! Thank you.

@danielmitterdorfer danielmitterdorfer merged commit 0b5a68f into elastic:master Jan 22, 2019
@danielmitterdorfer
Copy link
Member Author

Thanks for the quick review @ebadyano! :)

@danielmitterdorfer danielmitterdorfer deleted the errmsg_on_nonexisting_dir branch January 22, 2019 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Benchmark Candidate Management Anything affecting how Rally sets up Elasticsearch enhancement Improves the status quo :Track Management New operations, changes in the track format, track download changes and the like
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants