Include NOTICE.txt in release #622
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With this commit we generate a NOTICE.txt file and include it in the Rally wheel as well as the offline distribution package.
danielmitterdorfer
added
enhancement
|
|
||
| echo "Preparing NOTICE file" | ||
| __NOTICE_OUTPUT_FILE="${ABSOLUTE_DOWNLOAD_BIN_DIR}/NOTICE.txt" | ||
| source "${SCRIPT_SRC_HOME}/../create-notice.sh" |
There was a problem hiding this comment.
Referencing a script from a different directory is not nice. I think we should move our build-related scripts to a dedicated directory. However, I wanted to keep the scope of this PR as small as possible.
ebadyano
reviewed
Jan 3, 2019
| } | ||
|
|
||
| function main { | ||
| cat NOTICE > "${OUTPUT_FILE}" |
There was a problem hiding this comment.
Not sure how important it is, but does it make sense to use a variable name for NOTICE file? We are not likely to reuse it anywhere, so may be it's okay.
There was a problem hiding this comment.
IMHO it is ok to reference NOTICE here directly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this commit we generate a NOTICE.txt file and include it in the
Rally wheel as well as the offline distribution package.