Extract hits either as number or structured object #612
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With this commit we add the ability to extract metadata about the hit count of a search request regardless whether Elasticsearch returns it as a number (as in versions before 7.0) or as a structured object (as of 7.0). We also introduce a new metadata field `hits_relation` which indicates whether the hit count by Elasticsearch is accurate or an indication of a lower bound. Relates elastic/elasticsearch#35849 Closes elastic#611
danielmitterdorfer
added
enhancement
|
lgtm |
ebadyano
approved these changes
Dec 3, 2018
|
Thank you both! I just merged it. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this commit we add the ability to extract metadata about the hit
count of a search request regardless whether Elasticsearch returns it as
a number (versions before ES 7.0) or as a structured object (as of ES
7.0). We also introduce a new metadata field
hits_relationwhichindicates whether the hit count by Elasticsearch is accurate or an
indication of a lower bound.
Relates elastic/elasticsearch#35849
Closes #611