Always use remote branch for updates #575
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With this commit we always attempt to checkout the remote branch first. In a scenario where a user has already cloned the repository but uses the `--offline` flag the correct branches might not be proper local tracking branches but are already available on the target machine as remote branches. Closes elastic#573
danielmitterdorfer
added
bug
dliappis
approved these changes
Oct 12, 2018
|
Thanks for the review and no worries. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this commit we always attempt to checkout the remote branch first.
In a scenario where a user has already cloned the repository but uses
the
--offlineflag the correct branches might not be proper localtracking branches but are already available on the target machine as
remote branches.
Closes #573