Add ML API runners #570
Merged
Add ML API runners #570
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With this commit we add runners so Rally supports the most important ML-related API calls w.r.t. managing datafeeds and jobs.
danielmitterdorfer
added
enhancement
dliappis
approved these changes
Sep 11, 2018
docs/track.rst
Outdated
|
|
||
| * ``datafeed-id`` (mandatory): The name of the machine learning datafeed to start. | ||
| * ``body`` (optional, defaults to empty): Request body with start parameters. Please see the `start datafeed API <https://www.elastic.co/guide/en/elasticsearch/reference/current/ml-start-datafeed.html>`__ documentation for more details. | ||
| * ``start`` (optional, defaults to empty): Start timestamp of the datafeed. Please see the `start datafeed API <https://www.elastic.co/guide/en/elasticsearch/reference/current/ml-start-datafeed.html>`__ documentation for more details. |
There was a problem hiding this comment.
I am not certain if it makes sense to copy/paste the documentation link for every parameter here. Perhaps (for the sake of making the documentation less verbose) we could have the link before the parameters saying ... please see the ... for more details on any of the following parameters.
There was a problem hiding this comment.
Thanks for the suggestion which I pushed now in 0ff56fd.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this commit we add runners so Rally supports the most important
ML-related API calls w.r.t. managing datafeeds and jobs.