Disable automatic log rotation #560
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With this commit we disable automatic log rotation in Rally's out-of-the-box logging configuration because it can lead to race conditions (multiple processes attempting to rollover the log file). We also migrate existing configurations if possible (i.e. the user did not modify it) and provide an example configuration for `logrotate`. Closes #539
danielmitterdorfer
added
bug
dliappis
requested changes
Sep 10, 2018
| "propagate": false | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
I think we need a newline here, not just because of POSIX, but since earlier we read the file with read() the result will be something like: contents='line1\nline2' while the logging.json that Rally created itself in versions <1.0.1 has \n in the last line, so contents wouldn't match.
There was a problem hiding this comment.
Actually checked things again on a fresh installation on both MacOS and Linux and seems that using the currently released version of Rally, the logging.json file does not have a \n at the last line, so ignore my comment.
|
Thanks for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this commit we disable automatic log rotation in Rally's
out-of-the-box logging configuration because it can lead to race
conditions (multiple processes attempting to rollover the log file).
We also migrate existing configurations if possible (i.e. the user did
not modify it) and provide an example configuration for
logrotate.Closes #539