Update ccr stats endpoint #546
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update the endpoint and the unit tests to reflect the changes brought in [1] [1] elastic/elasticsearch#32350
Similar to the work done in 9b8974f
danielmitterdorfer
approved these changes
Aug 7, 2018
esrally/mechanic/telemetry.py
Outdated
| } | ||
| for shard_stats in stats: | ||
| shard_id = shard_stats.get("shard_id", None) | ||
| if shard_id is not None: |
There was a problem hiding this comment.
Probably a matter of taste but you could also write this as if "shard_id" in shard_stats and then use shard_stats["shard_id"] in the body.
There was a problem hiding this comment.
Thanks for the suggestion I prefer this as well; addressed in 581a69f
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the endpoint and the unit tests to reflect the changes brought
in [1]
Also simplify filtering ccr-stats related documents by adding
meta.name=ccr-statsto the metric documents, similarly to the workdone for node-stats in [2].
[1] elastic/elasticsearch#32350
[2] 9b8974f