Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add post_launch phase for Elasticsearch plugins #481

Merged
merged 1 commit into from
Apr 23, 2018
Merged

Add post_launch phase for Elasticsearch plugins #481

merged 1 commit into from
Apr 23, 2018

Conversation

danielmitterdorfer
Copy link
Member

With this commit we add a new bootstrap phase "post_launch" when
starting a cluster with Elasticsearch plugins.

Closes #479

@danielmitterdorfer
Add post_launch phase for Elasticsearch plugins
1221e80 
With this commit we add a new bootstrap phase "post_launch" when
starting a cluster with Elasticsearch plugins.
@danielmitterdorfer danielmitterdorfer added enhancement Improves the status quo :Benchmark Candidate Management Anything affecting how Rally sets up Elasticsearch labels Apr 23, 2018
@danielmitterdorfer danielmitterdorfer added this to the 0.10.2 milestone Apr 23, 2018
dliappis
dliappis approved these changes Apr 23, 2018
View reviewed changes
Copy link
Contributor

@dliappis dliappis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks for pushing this so quickly

@danielmitterdorfer danielmitterdorfer merged commit 78ba4ef into elastic:master Apr 23, 2018
@danielmitterdorfer danielmitterdorfer deleted the plugins-post-launch branch May 8, 2018 13:17
danielmitterdorfer added a commit to danielmitterdorfer/rally that referenced this pull request May 23, 2018
@danielmitterdorfer
Remove post_launch bootstrap phase
c2e7ba3 
With this commit we remove the unused bootstrap phase `post_launch`
which was intended to provide a car/plugin bootstrap phase after
Elasticsearch has been launched.

Relates elastic#481
@danielmitterdorfer danielmitterdorfer mentioned this pull request May 23, 2018
Merged
danielmitterdorfer added a commit that referenced this pull request May 23, 2018
@danielmitterdorfer
Remove post_launch bootstrap phase
80b0405 
With this commit we remove the unused bootstrap phase `post_launch`
which was intended to provide a car/plugin bootstrap phase after
Elasticsearch has been launched.

Relates #481
Relates #509
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dliappis dliappis dliappis approved these changes

Assignees
No one assigned
Labels
:Benchmark Candidate Management Anything affecting how Rally sets up Elasticsearch enhancement Improves the status quo
Projects
None yet
Milestone
0.11.0
Development

Successfully merging this pull request may close these issues.
2 participants
@danielmitterdorfer @dliappis