Create unique ids even for random conflicts #476
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With this commit we ensure that generated ids are always unique, even when generating random conflicts for bulk requests. The general strategy to simulate conflicts is as follows: 1. Generate a list of ids upfront. 2. Iterate through this list and pick a duplicate in 25% of all cases. In order to avoid accidentally creating more conflicts than expected, the list of ids generated in step one, needs to contain unique ids. However, we create ids at random without considering which ids have already been generated. This is now changed by first generating all ids and then shuffling them.
danielmitterdorfer
added
bug
dliappis
approved these changes
Apr 22, 2018
| all_ids[i] = "%10d" % (offset + i) | ||
| else: # RandomConflicts | ||
| all_ids[i] = "%10d" % rand(offset, offset + docs_to_index) | ||
| all_ids[i] = "%10d" % (offset + i) |
There was a problem hiding this comment.
Sticking to % as we are in the hot code path right? (instead of "{:>10d}".format(offset+i)?)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this commit we ensure that generated ids are always unique, even
when generating random conflicts for bulk requests. The general strategy
to simulate conflicts is as follows:
In order to avoid accidentally creating more conflicts than expected,
the list of ids generated in step one needs to contain unique ids.
However, we create ids at random without considering which ids have
already been generated. This is now changed by first generating all ids
and then shuffling them.