Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return "pages" as unit for scrolls #467

Merged

Conversation

danielmitterdorfer
Copy link
Member

With this commit we correct the base unit for scroll query throughput to
"pages" instead of "ops" as the returned number is also in returned
pages, not operations.

With this commit we correct the base unit for scroll query throughput to
"pages" instead of "ops" as the returned number is also in returned
pages, not operations.
@danielmitterdorfer danielmitterdorfer added bug Something's wrong :Metrics How metrics are stored, calculated or aggregated labels Apr 11, 2018
@danielmitterdorfer danielmitterdorfer added this to the 0.10.0 milestone Apr 11, 2018
Copy link
Contributor

@dliappis dliappis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@danielmitterdorfer danielmitterdorfer merged commit a4ae812 into elastic:master Apr 11, 2018
@danielmitterdorfer danielmitterdorfer deleted the correct-unit-for-scrolls branch April 11, 2018 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something's wrong :Metrics How metrics are stored, calculated or aggregated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants