Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default to upgrading packages with setuptools #465

Merged
merged 1 commit into from
Apr 10, 2018

Conversation

dliappis
Copy link
Contributor

Currently if a PyPi package version changes in setup.py,
e.g. upgrading the version of the elasticsearch Python client,
run.sh will not upgrade packages.

Always try to upgrade packages with setuptools before running the
Rally binary.

Relates #395

Currently if a PyPi package version changes in setup.py,
e.g. upgrading the version of the elasticsearch Python client,
`run.sh` will not upgrade packages.

Always try to upgrade packages with setuptools before running the
Rally binary.

Relates elastic#395
@dliappis dliappis added bug Something's wrong :Usability Makes Rally easier to use labels Apr 10, 2018
@dliappis dliappis added this to the 0.10.0 milestone Apr 10, 2018
Copy link
Member

@danielmitterdorfer danielmitterdorfer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM

@dliappis dliappis merged commit dcb7e82 into elastic:master Apr 10, 2018
@dliappis dliappis deleted the use-upgrade-with-setup-dot-py branch April 10, 2018 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something's wrong :Usability Makes Rally easier to use
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants