Remove 'index-settings' property #461
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With this commit we remove the deprecated track property `index-settings`. Since Rally 0.9.0, index settings can be provided via the `settings` property of the `create-index` operation hence making a specific property obsolete. Closes elastic#381
danielmitterdorfer
added
enhancement
|
Note: There is no need to adapt our default tracks because this has already been done in elastic/rally-tracks#41. |
dliappis
requested changes
Apr 10, 2018
docs/command_line_reference.rst
Outdated
| ] | ||
| } | ||
|
|
||
| Rally tracks can use the Jinja templating language and the construct ``{{ some_variable|default(0) }}`` that you can see above is a `feature of Jinja <http://jinja.pocoo.org/docs/2.10/templates/#default>`_ to define default values for variables. | ||
|
|
||
| We can see that it defines two variables: | ||
| We can see that it defines a variables: |
There was a problem hiding this comment.
s/a variables/a number of variables ?
docs/command_line_reference.rst
Outdated
|
|
||
| When we run this track, we can override these defaults: | ||
|
|
||
| * ``--track-params="replica_count:1,shard_count:3"`` will set the number of replicas to 1 and the number of shards to 3. | ||
| * ``--track-params="replica_count:1"`` will just set the number of replicas to 1 and just keep the default value of 5 shards. | ||
| * ``--track-params="bulk_size:2000,clients:16"`` will set the bulk size to 2000 and the number of clients for bulk indexing to 8. |
There was a problem hiding this comment.
You're right. Changed.
dliappis
approved these changes
Apr 10, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this commit we remove the deprecated track property
index-settings. Since Rally 0.9.0, index settings can be provided viathe
settingsproperty of thecreate-indexoperation hence making aspecific property obsolete.
Closes #381