Use composable index templates for metric indices #1811
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
inqueue
changed the title
gbanasiak
approved these changes
Dec 7, 2023
There was a problem hiding this comment.
LGTM.
What do you think about adding a migration guide entry explaining the consequences of this change to existing ES metric stores:
- legacy index templates are not removed automatically but composable index templates take precedence (applies to races, results and metrics),
- index template for annotations only gets created when
rally-annotationsindex is missing, so full migration from legacy to composable would require cumbersome renaming ofrally-annotationsindex, followed by Rally run (esrally add annotation ...), followed by reindexing of old data to newrally-annotationsindex.
Hi @gbanasiak, the requested changes have been applied. Would you mind taking another look? |
gbanasiak
approved these changes
Dec 21, 2023
Co-authored-by: Grzegorz Banasiak <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this commit, Rally is being switched from using legacy index templates to newer composable templates for metrics indices. Legacy index templates have been deprecated since ES 7.8 in favor of composable templates, and are not supported in ES Serverless. Rally metrics index templates have just one modification to make them composable templates. No other modifications have been made.
Closes #1810.