Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore HTTP 404 consistently in runners #1691

Merged
merged 3 commits into from
Mar 30, 2023
Merged

Ignore HTTP 404 consistently in runners #1691

merged 3 commits into from
Mar 30, 2023

Conversation

danielmitterdorfer
Copy link
Member

Some runners that deleted resources have ignored HTTP 404 already but we did not apply this consistently. With this commit, all runners that delete resources ignore HTTP 404 to avoid spurious request errors.

@danielmitterdorfer
Ignore HTTP 404 consistently in runners
490135c 
Some runners that deleted resources have ignored HTTP 404 already but we
did not apply this consistently. With this commit, all runners that
delete resources ignore HTTP 404 to avoid spurious request errors.
@danielmitterdorfer danielmitterdorfer added bug Something's wrong :Load Driver Changes that affect the core of the load driver such as scheduling, the measurement approach etc. labels Mar 24, 2023
@danielmitterdorfer danielmitterdorfer added this to the 2.8.0 milestone Mar 24, 2023
@danielmitterdorfer danielmitterdorfer self-assigned this Mar 24, 2023
b-deam
b-deam approved these changes Mar 30, 2023
View reviewed changes
Copy link
Member

@b-deam b-deam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this. LGTM.

Note to self that this'll all have to be refactored as part of #1673 anyway

@danielmitterdorfer danielmitterdorfer merged commit 53f6cc5 into elastic:master Mar 30, 2023
@danielmitterdorfer danielmitterdorfer deleted the consistent-ignore branch March 30, 2023 05:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@b-deam b-deam b-deam approved these changes

Assignees

@danielmitterdorfer danielmitterdorfer

Labels
bug Something's wrong :Load Driver Changes that affect the core of the load driver such as scheduling, the measurement approach etc.
Projects
None yet
Milestone
2.8.0
Development

Successfully merging this pull request may close these issues.
3 participants
@danielmitterdorfer @b-deam @pquentin