Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix supplier tests for aarch64 #1586

Merged
merged 1 commit into from
Sep 28, 2022

Conversation

b-deam
Copy link
Member

@b-deam b-deam commented Sep 27, 2022

Because TemplateRenderer.arch defaults to the arch of the system
invoking the tests, when invoked on an aarch64 system, the various
Car instances would throw exceptions 1 because they were
missing the architecture specific build commands added in
elastic/rally-teams#75

This commit fixes the existing tests to default to x86_64,
and adds two new aarch64 tests.

Footnotes

  1. (e.g. esrally.exceptions.SystemSetupError: Car "default" requires config key "system.build_command.arch")

@b-deam b-deam added the bug Something's wrong label Sep 27, 2022
@b-deam b-deam self-assigned this Sep 27, 2022
Copy link
Member

@pquentin pquentin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this looks good to me!

I find it sad that Elasticsearch forces us to have so many conditions just because x64 is the default arch and is left out from the build command and generated tarball. Well, that's the way it is.

@b-deam b-deam merged commit 4fbf147 into elastic:master Sep 28, 2022
@pquentin pquentin added this to the 2.7.0 milestone Nov 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something's wrong
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants