Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Link to the 7.14.0 ES Python client docs. #1554

Merged
merged 3 commits into from
Aug 17, 2022
Merged

Link to the 7.14.0 ES Python client docs. #1554

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
18adc2c
Link to the 7.14.0 ES Python client docs.
Aug 1, 2022
8fb9a3d
Programmatically set the ES client version in the docs build.
Aug 11, 2022
cb68d64
Merge branch 'master' into link-to-7.14-python-client-docs
Aug 11, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/command_line_reference.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -663,7 +663,7 @@ By default, the command line reporter will print the results only on standard ou

With this option you can customize Rally's internal Elasticsearch client.

It accepts a list of comma-separated key-value pairs. The key-value pairs have to be delimited by a colon. These options are passed directly to the Elasticsearch Python client API. See `their documentation on a list of supported options <http://elasticsearch-py.readthedocs.io/en/master/api.html#elasticsearch.Elasticsearch>`_.
It accepts a list of comma-separated key-value pairs. The key-value pairs have to be delimited by a colon. These options are passed directly to the Elasticsearch Python client API. See `their documentation on a list of supported options <https://elasticsearch-py.readthedocs.io/en/v7.14.0/api.html#elasticsearch>`_.
Copy link
Contributor

@dliappis dliappis Aug 3, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the sake of not having to remember changing the version here when we upgrade elasticsearch[async] could we leverage a variable, similar to how we do for MIN_PY_VER? This is achieved with real python code on docs/conf.py so we could determine the version programmatically.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, didn't even occur to me. I'll do that.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done in 8fb9a3d


We support the following data types:

Expand Down