-
Notifications
You must be signed in to change notification settings - Fork 314
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch from setuptools to hatchling #1551
Conversation
In anticipation of move to flit.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I tested locally and also with some internal tooling that installs Rally from source using this branch.
The merge conflict is minor BTW.
Simply having a pyproject.toml file with a build-system entry as done in elastic#1548 means that `--no-use-pep517` is going to fail. This pull request integrates the relevant part of elastic#1551 to stop doing that. We need to merge this before the nightly benchmarks run.
This is still true today
I merged from master and fixed the conflicts. I also reinstated This pull request is now even smaller. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Python packaging is evolving quite rapidly and there are now multiple alternatives to setuptools. Additionally:
--no-use-pep517
in various placesI hesitated between flit (minimal and simple, did not want to be the default recommendation) and hatch (more popular, doing more things, actively maintained). The main difference for our use case is how we select files that go in the distribution, and hatch is the first that I was able to get to work. All other parts are standardized, so switching is going to be easy until we start using more hatch features.
I tested:
make install
), running it with ./rallyBefore merging, we'll have to: