Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run lint with pre-commit #1546

Merged
merged 7 commits into from
Aug 22, 2022
Merged

Run lint with pre-commit #1546

merged 7 commits into from
Aug 22, 2022

Conversation

pquentin
Copy link
Member

@pquentin pquentin commented Jul 25, 2022 •
edited
Loading

pre-commit is faster because it only applies to modified files and runs in parallel. It's also more convenient because it runs on commits, which ensures you don't forget lint.

@pquentin pquentin added the cleanup Linter changes, reformatting, removal of unused code etc. label Jul 25, 2022
@pquentin pquentin added this to the 2.6.1 milestone Jul 25, 2022
@pquentin pquentin self-assigned this Jul 25, 2022
@pquentin pquentin changed the title Run lint with precommit Run lint with pre-commit Jul 27, 2022
michaelbaamonde
michaelbaamonde approved these changes Aug 1, 2022
View reviewed changes
Copy link
Contributor

@michaelbaamonde michaelbaamonde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is cool. Worked well for me locally. Thanks!

@pquentin pquentin merged commit d5d79ae into elastic:master Aug 22, 2022
@pquentin pquentin mentioned this pull request Aug 26, 2022
Merged
@pquentin pquentin added the :misc Changes that don't affect users directly: linter fixes, test improvements, etc. label Nov 2, 2022
@pquentin pquentin deleted the precommit branch February 16, 2023 06:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelbaamonde michaelbaamonde michaelbaamonde approved these changes

Assignees

@pquentin pquentin

Labels
cleanup Linter changes, reformatting, removal of unused code etc. :misc Changes that don't affect users directly: linter fixes, test improvements, etc.
Projects
None yet
Milestone
2.7.0
Development

Successfully merging this pull request may close these issues.
2 participants
@pquentin @michaelbaamonde