Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make git.clone remote kwarg-only #1529

Merged
merged 4 commits into from
Jun 23, 2022
Merged

Make git.clone remote kwarg-only #1529

merged 4 commits into from
Jun 23, 2022

Conversation

pquentin
Copy link
Member

This is the discussed follow-up to #1527.

@pquentin pquentin added cleanup Linter changes, reformatting, removal of unused code etc. :internal Changes for internal, undocumented features: e.g. experimental, release scripts labels Jun 22, 2022
@pquentin pquentin added this to the 2.5.1 milestone Jun 22, 2022
@pquentin pquentin requested a review from dliappis June 22, 2022 12:48
@pquentin pquentin self-assigned this Jun 22, 2022
dliappis
dliappis approved these changes Jun 22, 2022
View reviewed changes
Copy link
Contributor

@dliappis dliappis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thank you. Now the code reads as if we were typing the git commands in CLI which I find a great readability/extensibility improvement.

@pquentin pquentin merged commit 5fa5b4a into elastic:master Jun 23, 2022
@pquentin pquentin modified the milestones: 2.5.1, 2.5.0 Jun 23, 2022
@pquentin pquentin added :misc Changes that don't affect users directly: linter fixes, test improvements, etc. and removed :internal Changes for internal, undocumented features: e.g. experimental, release scripts labels Jun 23, 2022
@pquentin pquentin deleted the git-remote-agnostic branch July 25, 2022 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dliappis dliappis dliappis approved these changes

Assignees

@pquentin pquentin

Labels
cleanup Linter changes, reformatting, removal of unused code etc. :misc Changes that don't affect users directly: linter fixes, test improvements, etc.
Projects
None yet
Milestone
2.5.0
Development

Successfully merging this pull request may close these issues.
2 participants
@pquentin @dliappis