Instantiate SubClient only with kwargs #1505
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When SubClient could only be used to mock the node stats API, this was clear, but it's no longer the case. Thankfully most usage was using keyword arguments already, so it could be enforced with low effort. We apply this to the similar Client and TransportClient classes too.
pquentin
added
cleanup
DJRickyB
approved these changes
Jun 14, 2022
michaelbaamonde
pushed a commit
to michaelbaamonde/rally
that referenced
this pull request
Jun 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When SubClient could only be used to mock the node stats API, this was
clear, but it's no longer the case. Thankfully most usage was using
keyword arguments already, so it could be enforced with low effort.
We apply this to the similar Client and TransportClient classes too.
I noticed this when reviewing #1499 from @j-bennet.