Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flexible support of GC collectors in telemetry. #1499

Merged

Conversation

j-bennet
Copy link
Contributor

Support collectors other than young and old when collecting GC stats in telemetry.

Fixes #1052.

@j-bennet j-bennet marked this pull request as draft May 24, 2022 20:59
@j-bennet j-bennet marked this pull request as ready for review May 24, 2022 22:01
Copy link
Member

@pquentin pquentin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, this works perfectly! This is a very polished contribution, it was a pleasure to review. Per our process, not merging, feel free to do it yourself.

If you're looking for a follow up task, since we now store ZGC information in the metrics store, should we go as far as adding the data in the race report and comparison report? This would involve modifying metrics.py and reporter.py, see #1416 for an example.

@j-bennet j-bennet merged commit e8fb7ab into elastic:master May 25, 2022
@j-bennet j-bennet deleted the j-bennet/1052-telemetry-gc-collectors branch May 25, 2022 15:59
@j-bennet
Copy link
Contributor Author

@pquentin

If you're looking for a follow up task, since we now store ZGC information in the metrics store, should we go as far as adding the data in the race report and comparison report? This would involve modifying metrics.py and reporter.py, see #1416 for an example.

Nice, thanks for the tip! I'll follow up on that.

@pquentin pquentin added the enhancement Improves the status quo label Jun 23, 2022
@pquentin pquentin added this to the 2.5.0 milestone Jun 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improves the status quo
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fail Gracefully when Additional Telemetry Stats are Unavailable
2 participants