Pick up data streams in disk-usage-stats telemetry #1455
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some of our tracks just declare data streams.
DJRickyB
suggested changes
Mar 21, 2022
tests/telemetry_test.py
Outdated
| @@ -4150,24 +4150,31 @@ def test_logs_warning_on_missing_stats(self, metrics_put_value_cluster_level, me | |||
|
|
|||
| class TestDiskUsageStats: | |||
| @mock.patch("elasticsearch.Elasticsearch") | |||
| def test_uses_indices_param_by_default(self, es): | |||
| def test_uses_indices_and_data_streams_by_default(self, es): | |||
There was a problem hiding this comment.
can you split this case, please? Per the docs, we can only use one or the other
The indices section contains a list of all indices that are used by this track. Cannot be used if the data-streams section is specified.
tests/telemetry_test.py
Outdated
|
|
||
| @mock.patch("elasticsearch.Elasticsearch") | ||
| def test_uses_indices_param_if_specified(self, es): | ||
| cfg = create_config() | ||
| metrics_store = metrics.EsMetricsStore(cfg) | ||
| tc = TransportClient(response={"_shards": {"failed": 0}}) | ||
| es = Client(transport_client=tc) | ||
| device = telemetry.DiskUsageStats({"disk-usage-stats-indices": "foo,bar"}, es, metrics_store, ["baz"]) | ||
| device = telemetry.DiskUsageStats( | ||
| {"disk-usage-stats-indices": "foo,bar"}, es, metrics_store, index_names=["baz"], data_stream_names=["not_this"] |
There was a problem hiding this comment.
Likewise would be good here to only use index_names or data_stream_names
DJRickyB
added
bug
DJRickyB
approved these changes
Mar 22, 2022
|
Nice! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of our tracks just declare data streams.