Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop leading users away from finding errors in docs #1447

Merged
merged 2 commits into from
Mar 1, 2022

Conversation

pquentin
Copy link
Member

There's a link to the metrics store page below and the first part of the
section does not need a metrics store. This confused me multiple times.

There's a link to the metrics store page below and the first part of the
section does not need a metrics store. This confused me multiple times.
@pquentin pquentin added the :Docs Changes to the documentation label Feb 24, 2022
@pquentin pquentin added this to the 2.4.0 milestone Feb 24, 2022
@pquentin pquentin self-assigned this Feb 24, 2022
Copy link
Contributor

@DJRickyB DJRickyB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine. I'd just as soon delete it, I don't think docs need transitional language

docs/recipes.rst Outdated
@@ -215,7 +215,7 @@ This behavior can also be changed, by invoking Rally with the :ref:`--on-error <

esrally race --track=geonames --on-error=abort

Errors can also be investigated if you have configured a :doc:`dedicated Elasticsearch metrics store </configuration>`.
Errors can also be investigated: this is what the next section is about.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure we need this line at all

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed, I removed it

@pquentin pquentin changed the title Stop leading users away from finding errors Stop leading users away from finding errors in docs Mar 1, 2022
@pquentin pquentin merged commit 70a9c93 into elastic:master Mar 1, 2022
@pquentin pquentin deleted the investigate-errors-clarity branch March 1, 2022 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Docs Changes to the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants