Derive correct artifact name for ARM architecture #1418
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To download an Elasticsearch artifact, Rally needs to resolve the CPU architecture of the current system to download the correct distribution tarball. This does not work currently on Macs with ARM M1 chips. These are reported as `arm64` but the Elasticsearch artifact uses `aarch64` to refer to this CPU architecture. Consequently, downloading an artifact on ARM-based Macs fails unless the user specifies `--target-arch=aarch64`. With this commit we detect this case and ensure that the correct artifact can be downloaded. We intentionally change the architecture specifier only in the component that is responsible for deriving the download URL for artifacts but keep referring to this CPU architecture as `arm64` in other parts of the code, just as it is reported by the OS.
danielmitterdorfer
added
bug
pquentin
approved these changes
Jan 17, 2022
Co-authored-by: Quentin Pradet <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To download an Elasticsearch artifact, Rally needs to resolve the CPU
architecture of the current system to download the correct distribution
tarball. This does not work currently on Macs with ARM M1 chips. These
are reported as
arm64but the Elasticsearch artifact usesaarch64torefer to this CPU architecture. Consequently, downloading an artifact on
ARM-based Macs fails unless the user specifies
--target-arch=aarch64.With this commit we detect this case and ensure that the correct
artifact can be downloaded. We intentionally change the architecture
specifier only in the component that is responsible for deriving the
download URL for artifacts but keep referring to this CPU architecture
as
arm64in other parts of the code, just as it is reported by the OS.