Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for listing nested tracks #1319

Merged
merged 2 commits into from
Sep 2, 2021

Conversation

DJRickyB
Copy link
Contributor

@DJRickyB DJRickyB commented Aug 31, 2021

with this commit we add support for listing nested tracks in git-based track repositories. Previously, esrally list tracks would only list top-level directories in a target track repo which contained a track.json. This change causes full recursive search in the track repository, to better support the idea of "nested" track structures.

Fixes #1086

@DJRickyB DJRickyB added enhancement Improves the status quo :Track Management New operations, changes in the track format, track download changes and the like labels Aug 31, 2021
@DJRickyB DJRickyB added this to the 2.3.0 milestone Aug 31, 2021
@DJRickyB DJRickyB requested a review from ebadyano August 31, 2021 14:42
@DJRickyB DJRickyB self-assigned this Aug 31, 2021
@DJRickyB DJRickyB changed the title add support for listing nested tracks Add support for listing nested tracks Aug 31, 2021
Copy link
Contributor

@ebadyano ebadyano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you for adding this

@DJRickyB DJRickyB merged commit 17c55a1 into elastic:master Sep 2, 2021
@DJRickyB DJRickyB deleted the nested-tracks branch September 2, 2021 12:01
DJRickyB added a commit that referenced this pull request Sep 2, 2021
DJRickyB pushed a commit that referenced this pull request Sep 2, 2021
@DJRickyB DJRickyB restored the nested-tracks branch September 2, 2021 14:24
DJRickyB added a commit that referenced this pull request Sep 22, 2021
DJRickyB pushed a commit that referenced this pull request Sep 22, 2021
…" (#1343)

This commit was previously reverted, due to a false positive in our testing. See #1086, #1319, and #1320 for full detail.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improves the status quo :Track Management New operations, changes in the track format, track download changes and the like
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support Nested Tracks
2 participants