Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop relative-time-ms metric #1291

Merged

Conversation

danielmitterdorfer
Copy link
Member

With this commit we drop the metric relative-time-ms which we have
introduced for a transition period. This property is superseded by
relative-time which contains the same value.

Relates #1198

With this commit we drop the metric `relative-time-ms` which we have
introduced for a transition period. This property is superseded by
`relative-time` which contains the same value.

Relates elastic#1198
@danielmitterdorfer danielmitterdorfer added enhancement Improves the status quo :Metrics How metrics are stored, calculated or aggregated breaking Non-backwards compatible change labels Jun 24, 2021
@danielmitterdorfer danielmitterdorfer added this to the 2.3.0 milestone Jun 24, 2021
@danielmitterdorfer danielmitterdorfer self-assigned this Jun 24, 2021
Copy link
Contributor

@ebadyano ebadyano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thank you

@pquentin
Copy link
Member

Sorry for the conflicts, I fixed them in pquentin@6e4c9a2

@danielmitterdorfer
Copy link
Member Author

Sorry for the conflicts, I fixed them in pquentin/rally@6e4c9a2

Thanks for doing this! I had the changes already merged locally and missed your comment.

@danielmitterdorfer danielmitterdorfer merged commit b476261 into elastic:master Jul 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking Non-backwards compatible change enhancement Improves the status quo :Metrics How metrics are stored, calculated or aggregated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants