Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not treat increase in transform processing/indexing/search time as improvement #1287

Merged
merged 1 commit into from
Jun 21, 2021
Merged

Do not treat increase in transform processing/indexing/search time as improvement #1287

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions esrally/reporter.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -457,21 +457,21 @@ def _report_transform_processing_times(self, baseline_stats, contender_stats):
if contender["id"] == transform_id:
lines.append(
self._line("Transform processing time", baseline["mean"], contender["mean"],
transform_id, baseline["unit"], treat_increase_as_improvement=True))
transform_id, baseline["unit"], treat_increase_as_improvement=False))
for baseline in baseline_stats.total_transform_index_times:
transform_id = baseline["id"]
for contender in contender_stats.total_transform_index_times:
if contender["id"] == transform_id:
lines.append(
self._line("Transform indexing time", baseline["mean"], contender["mean"],
transform_id, baseline["unit"], treat_increase_as_improvement=True))
transform_id, baseline["unit"], treat_increase_as_improvement=False))
for baseline in baseline_stats.total_transform_search_times:
transform_id = baseline["id"]
for contender in contender_stats.total_transform_search_times:
if contender["id"] == transform_id:
lines.append(
self._line("Transform search time", baseline["mean"], contender["mean"],
transform_id, baseline["unit"], treat_increase_as_improvement=True))
transform_id, baseline["unit"], treat_increase_as_improvement=False))
for baseline in baseline_stats.total_transform_throughput:
transform_id = baseline["id"]
for contender in contender_stats.total_transform_throughput:
Expand Down