Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-introduce relative-time property #1273

Conversation

danielmitterdorfer
Copy link
Member

With this commit we introduce the property relative-time for metrics
documents again. Contrary to Rally versions prior to 2.1.0, this
property contains the relative time since Rally started execution of a
task denoted in milliseconds, instead of microseconds. We also
deprecate the ancillary property relative-time-ms which will be
dropped in the next minor release in favor of relative-time.

Relates #1198

With this commit we introduce the property `relative-time` for metrics
documents again. Contrary to Rally versions prior to 2.1.0, this
property contains the relative time since Rally started execution of a
task denoted in milliseconds, instead of microseconds. We also
deprecate the ancillary property `relative-time-ms` which will be
dropped in the next minor release in favor of `relative-time`.

Relates elastic#1198
@danielmitterdorfer danielmitterdorfer added enhancement Improves the status quo :Metrics How metrics are stored, calculated or aggregated labels May 28, 2021
@danielmitterdorfer danielmitterdorfer added this to the 2.2.1 milestone May 28, 2021
@danielmitterdorfer danielmitterdorfer self-assigned this May 28, 2021
Copy link
Contributor

@ebadyano ebadyano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@danielmitterdorfer danielmitterdorfer merged commit dc66d00 into elastic:master Jun 7, 2021
@danielmitterdorfer danielmitterdorfer deleted the deprecated-relative-time-ms branch June 7, 2021 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improves the status quo :Metrics How metrics are stored, calculated or aggregated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants