-
Notifications
You must be signed in to change notification settings - Fork 313
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consolidate and improve track/team repo revision logic docs #1265
Consolidate and improve track/team repo revision logic docs #1265
Conversation
Currently the repository version matching logic for Rally tracks/teams is duplicated in Rally docs as well as README files in in our standard tracks/teams repositories. Update docs consolidating existing documentation from elastic/rally-tracks and elastic/rally-teams Relates: - elastic/rally-tracks#162 - elastic/rally-teams#62
With elastic/rally#1265 the official Rally docs should be the point of reference on how the versioning scheme works. Remove versioning scheme docs duplication and reference the official docs. Closes elastic#162
With elastic/rally#1265 the official Rally docs should be the point of reference on how the versioning scheme works. Remove versioning scheme docs duplication and reference the official docs. Closes elastic#62
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I left one nit but no need for another review round.
docs/track.rst
Outdated
|
||
Assuming the track repository has several branches, the order is: | ||
#. *Exact match major.minor.patch-extension_label* (e.g. ``7.0.0-beta1``) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: A few lines above in MAJOR.MINOR.PATCH-SUFFIX
we call this SUFFIX
but here we call it extension_label
. We should align the names.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed. Fixed in 3a4ca08
With elastic/rally#1265 the official Rally docs should be the point of reference on how the versioning scheme works. Remove versioning scheme docs duplication and reference the official docs. Closes #162
With elastic/rally#1265 the official Rally docs should be the point of reference on how the versioning scheme works. Remove versioning scheme docs duplication and reference the official docs. Closes #62
With elastic/rally#1265 the official Rally docs should be the point of reference on how the versioning scheme works. Remove versioning scheme docs duplication and reference the official docs. Closes #162
With elastic/rally#1265 the official Rally docs should be the point of reference on how the versioning scheme works. Remove versioning scheme docs duplication and reference the official docs. Closes #162
With elastic/rally#1265 the official Rally docs should be the point of reference on how the versioning scheme works. Remove versioning scheme docs duplication and reference the official docs. Closes #162
With elastic/rally#1265 the official Rally docs should be the point of reference on how the versioning scheme works. Remove versioning scheme docs duplication and reference the official docs. Closes #162
With elastic/rally#1265 the official Rally docs should be the point of reference on how the versioning scheme works. Remove versioning scheme docs duplication and reference the official docs. Closes #162
With elastic/rally#1265 the official Rally docs should be the point of reference on how the versioning scheme works. Remove versioning scheme docs duplication and reference the official docs. Closes #162
With elastic/rally#1265 the official Rally docs should be the point of reference on how the versioning scheme works. Remove versioning scheme docs duplication and reference the official docs. Closes #62
With elastic/rally#1265 the official Rally docs should be the point of reference on how the versioning scheme works. Remove versioning scheme docs duplication and reference the official docs. Closes #62
With elastic/rally#1265 the official Rally docs should be the point of reference on how the versioning scheme works. Remove versioning scheme docs duplication and reference the official docs. Closes #62
With elastic/rally#1265 the official Rally docs should be the point of reference on how the versioning scheme works. Remove versioning scheme docs duplication and reference the official docs. Closes #62
With elastic/rally#1265 the official Rally docs should be the point of reference on how the versioning scheme works. Remove versioning scheme docs duplication and reference the official docs. Closes #62
With elastic/rally#1265 the official Rally docs should be the point of reference on how the versioning scheme works. Remove versioning scheme docs duplication and reference the official docs. Closes #62
With elastic/rally#1265 the official Rally docs should be the point of reference on how the versioning scheme works. Remove versioning scheme docs duplication and reference the official docs. Closes #62
Currently the repository version matching logic for Rally tracks/teams
is duplicated in Rally docs as well as README files in in our standard
tracks/teams repositories.
Update docs consolidating existing documentation from
elastic/rally-tracks and elastic/rally-teams
Relates: