Add pyenv shims to PATH #1263
Merged
Add pyenv shims to PATH #1263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Recently the pyenv init command does not add pyenv shims to the `PATH` anymore. This needs to be done now explicitly with a new command. We add the command in build scripts and our documentation to make sure shims are available.
dliappis
approved these changes
May 10, 2021
Makefile
Outdated
| @@ -29,8 +29,7 @@ VENV_ACTIVATE = . $(VENV_ACTIVATE_FILE) | |||
| VEPYTHON = $(VENV_NAME)/bin/$(PY_BIN) | |||
| VEPYLINT = $(VENV_NAME)/bin/pylint | |||
| PYENV_ERROR = "\033[0;31mIMPORTANT\033[0m: Please install pyenv.\n" | |||
| PYENV_PATH_ERROR = "\033[0;31mIMPORTANT\033[0m: Please add $(HOME)/$(PYENV_REGEX) to your PATH env.\n" | |||
| PYENV_PREREQ_HELP = "\033[0;31mIMPORTANT\033[0m: please add \033[0;31meval \"\$$(pyenv init -)\"\033[0m to your bash profile and restart your terminal before proceeding any further.\n" | |||
| PYENV_PREREQ_HELP = "\033[0;31mIMPORTANT\033[0m: please add \033[0;31meval \"\$$(pyenv init -)\"\033[0m and \033[0;31meval \"\$$(pyenv init --path)\"\033[0m to your bash profile and restart your terminal before proceeding any further.\n" | |||
There was a problem hiding this comment.
As discussed offline maybe we just reference the instructions; the most authoritative form I think is by executing pyenv init.
There was a problem hiding this comment.
Addressed in ffb25ba.
docs/developing.rst
Outdated
| @@ -6,7 +6,7 @@ Prerequisites | |||
|
|
|||
| Install the following software packages: | |||
|
|
|||
| * Pyenv installed and ``eval "$(pyenv init -)"`` is added to the shell configuration file. For more details please refer to the PyEnv `installation instructions <https://github.com/pyenv/pyenv#installation>`_. | |||
| * Pyenv installed, ``eval "$(pyenv init -)"`` and ``eval "$(pyenv init --path)"`` is added to the shell configuration file. For more details please refer to the PyEnv `installation instructions <https://github.com/pyenv/pyenv#installation>`_. | |||
There was a problem hiding this comment.
Likewise here, let's reference pyenv init for the prerequisites.
There was a problem hiding this comment.
Addressed in ffb25ba.
| @@ -44,6 +44,7 @@ function build { | |||
| export LC_ALL=en_US.UTF-8 | |||
| update_pyenv | |||
| eval "$(pyenv init -)" | |||
| eval "$(pyenv init --path)" | |||
There was a problem hiding this comment.
Maybe we should leave a breadcrumb where this comes from i.e. either pyenv/pyenv#1906 (comment) or the issue itself pyenv/pyenv#1906
There was a problem hiding this comment.
Addressed in ffb25ba.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recently the pyenv init command does not add pyenv shims to the
PATHanymore. This needs to be done now explicitly with a new command. We add
the command in build scripts and our documentation to make sure shims
are available.