Ensure stable mappings for metrics #1209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With this commit we disable dynamic detection of dates for documents in the metrics store. By disabling this feature, any dynamic values (like track parameters or user tags) that look like tags are mapped as keywords instead of as dates. These values should only be treated as keywords and are not meant to be used e.g. in range queries. Furthermore, this ensures that we don't cause trouble when date formats conflict in such dynamic values. Note that properties that are explicitly mapped as dates (e.g. `@timestamp`) are not affected by this change and will still be mapped as dates.
danielmitterdorfer
added
bug
dliappis
reviewed
Mar 16, 2021
No, because this only changes the index template which applies only to newly created indices. So the change then applies only to the new index. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this commit we disable dynamic detection of dates for documents in
the metrics store. By disabling this feature, any dynamic values (like
track parameters or user tags) that look like dates are mapped as
keywords instead of as dates. These values should only be treated as
keywords and are not meant to be used e.g. in range queries.
Furthermore, this ensures that we don't cause trouble when date formats
conflict in such dynamic values. Note that properties that are
explicitly mapped as dates (e.g.
@timestamp) are not affected by thischange and will still be mapped as dates.